fix: improve browser launcher types#1318
Merged
B4nan merged 1 commit intoapify:masterfrom Mar 28, 2022
barjin:feat/launcherTypes
Merged
fix: improve browser launcher types#1318B4nan merged 1 commit intoapify:masterfrom barjin:feat/launcherTypes
B4nan merged 1 commit intoapify:masterfrom
barjin:feat/launcherTypes
Conversation
B4nan
approved these changes
Mar 28, 2022
| * @typedef PuppeteerLaunchContext | ||
| * @property {LaunchOptions} [launchOptions] | ||
| * `puppeteer.launch` [options](https://pptr.dev/#?product=Puppeteer&version=v5.5.0&show=api-puppeteerlaunchoptions) | ||
| * @property {Parameters<PuppeteerNode['launch']>[0]} [launchOptions] |
Member
There was a problem hiding this comment.
same here, i kinda expect this won't work with the jsdoc extraction properly, but lets merge and see
B4nan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSDoc type update
Closes #1260