-
Notifications
You must be signed in to change notification settings - Fork 59
fix: error when content type is json #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MQ37
reviewed
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address the change and LGTM, thank you 👍
MQ37
approved these changes
Sep 8, 2025
MQ37
added a commit
that referenced
this pull request
Sep 9, 2025
commit 20e6753 Author: Apify Release Bot <noreply@apify.com> Date: Tue Sep 9 11:41:31 2025 +0000 chore(release): Update changelog, package.json and manifest.json versions [skip ci] commit 7ef726d Author: Jakub Kopecký <themq37@gmail.com> Date: Tue Sep 9 13:40:04 2025 +0200 feat: improve actor tool output (#260) * feat: improve actor tool output * update readme * fix output tool, write test for that * add test based on Zuzka suggestion * lint * fix output response order so LLM does not lose the instructions * refactor: unify string list parsing logic * fix the tests - order of the Actor run response messages * Update src/utils/schema-generation.ts Co-authored-by: Michal Kalita <kalita.michal@gmail.com> * address review comments * add get-actor-output tools note about when its loaded --------- Co-authored-by: Michal Kalita <kalita.michal@gmail.com> commit 279293f Author: Michal Kalita <kalita.michal@gmail.com> Date: Mon Sep 8 12:05:25 2025 +0200 fix: error when content type is json (#265) * fix: error when content type is json * fix: do not make json schema formatted for human readable commit 4659e03 Author: Apify Release Bot <noreply@apify.com> Date: Thu Sep 4 12:30:50 2025 +0000 chore(release): Update changelog, package.json and manifest.json versions [skip ci]
MQ37
added a commit
that referenced
this pull request
Sep 9, 2025
commit 20e6753 Author: Apify Release Bot <noreply@apify.com> Date: Tue Sep 9 11:41:31 2025 +0000 chore(release): Update changelog, package.json and manifest.json versions [skip ci] commit 7ef726d Author: Jakub Kopecký <themq37@gmail.com> Date: Tue Sep 9 13:40:04 2025 +0200 feat: improve actor tool output (#260) * feat: improve actor tool output * update readme * fix output tool, write test for that * add test based on Zuzka suggestion * lint * fix output response order so LLM does not lose the instructions * refactor: unify string list parsing logic * fix the tests - order of the Actor run response messages * Update src/utils/schema-generation.ts Co-authored-by: Michal Kalita <kalita.michal@gmail.com> * address review comments * add get-actor-output tools note about when its loaded --------- Co-authored-by: Michal Kalita <kalita.michal@gmail.com> commit 279293f Author: Michal Kalita <kalita.michal@gmail.com> Date: Mon Sep 8 12:05:25 2025 +0200 fix: error when content type is json (#265) * fix: error when content type is json * fix: do not make json schema formatted for human readable commit 4659e03 Author: Apify Release Bot <noreply@apify.com> Date: Thu Sep 4 12:30:50 2025 +0000 chore(release): Update changelog, package.json and manifest.json versions [skip ci]
MQ37
added a commit
that referenced
this pull request
Sep 12, 2025
* feat: improve actor tool output * update readme * fix output tool, write test for that * add test based on Zuzka suggestion * lint * fix output response order so LLM does not lose the instructions * refactor: unify string list parsing logic * fix the tests - order of the Actor run response messages * Update src/utils/schema-generation.ts Co-authored-by: Michal Kalita <kalita.michal@gmail.com> * address review comments * feat: agentci payments v2 * add skyfire usage resource, fix skyfire pay id handling and passing to Actor * add skyfire instructions also to the call-actor info step result content * Squashed commit of the following: commit 20e6753 Author: Apify Release Bot <noreply@apify.com> Date: Tue Sep 9 11:41:31 2025 +0000 chore(release): Update changelog, package.json and manifest.json versions [skip ci] commit 7ef726d Author: Jakub Kopecký <themq37@gmail.com> Date: Tue Sep 9 13:40:04 2025 +0200 feat: improve actor tool output (#260) * feat: improve actor tool output * update readme * fix output tool, write test for that * add test based on Zuzka suggestion * lint * fix output response order so LLM does not lose the instructions * refactor: unify string list parsing logic * fix the tests - order of the Actor run response messages * Update src/utils/schema-generation.ts Co-authored-by: Michal Kalita <kalita.michal@gmail.com> * address review comments * add get-actor-output tools note about when its loaded --------- Co-authored-by: Michal Kalita <kalita.michal@gmail.com> commit 279293f Author: Michal Kalita <kalita.michal@gmail.com> Date: Mon Sep 8 12:05:25 2025 +0200 fix: error when content type is json (#265) * fix: error when content type is json * fix: do not make json schema formatted for human readable commit 4659e03 Author: Apify Release Bot <noreply@apify.com> Date: Thu Sep 4 12:30:50 2025 +0000 chore(release): Update changelog, package.json and manifest.json versions [skip ci] * fix the port already in use issue with tests * lint * remove the try catch that was rethrowing generic error in callActorGetDataset * add skyfire seller id and pay id to the get actor output * lint * rename env var * include seller id conditionally in the instructions * handle skyfire pay id in get actor output * change usd amount --------- Co-authored-by: Michal Kalita <kalita.michal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264
It was a simple issue, type JSON is not allowed, it must be text.