Skip to content

Readme improvements #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2023
Merged

Readme improvements #126

merged 1 commit into from
Oct 23, 2023

Conversation

@vdusek
Copy link
Contributor

@vdusek vdusek commented Oct 23, 2023

I encountered a few minor flaws in the README. This PR fixes them.

  • capitalization of Actor;
  • using HTTPX instead of blocking Requests library;
  • using identifier actor_input instead of just input (since input is a built-in function and the code render engine renders it as a function - bold);
  • add comments to the code example.

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Oct 23, 2023
@vdusek vdusek added this to the 75th sprint - Tooling team milestone Oct 23, 2023
@vdusek vdusek self-assigned this Oct 23, 2023
@vdusek vdusek requested a review from jirimoravcik October 23, 2023 15:48
@vdusek vdusek merged commit e287144 into master Oct 23, 2023
@vdusek vdusek deleted the readme-improvement branch October 23, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jirimoravcik jirimoravcik jirimoravcik approved these changes

Assignees

@vdusek vdusek

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Milestone

75th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

3 participants

@vdusek @jirimoravcik