Skip to content

Add comment why not to use ~= clause in deps definition #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Add comment why not to use ~= clause in deps definition #154

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e64573c
Use compatible release clause in deps definition
vdusek Dec 5, 2023
96d1934
Revert changes and add comment
vdusek Dec 5, 2023
8a66f2d
revert changelog
vdusek Dec 5, 2023
6227ba8
uses >= for scrapy
vdusek Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,15 @@ classifiers = [
]

requires-python = ">=3.8"

# We use inclusive ordered comparison clause for non-Apify packages intentionally in order to enhance the Apify SDK's
# compatibility with a wide range of external packages. This decision was discussed in detail in the following PR:
# https://github.com/apify/apify-sdk-python/pull/154
dependencies = [
"aiofiles >= 22.1.0",
"aioshutil >= 1.0",
"apify-client ~= 1.6.0",
"apify-shared ~= 1.1.0",
"aiofiles >= 22.1.0",
"aioshutil >= 1.0",
"colorama >= 0.4.6",
"cryptography >= 39.0.0",
"httpx >= 0.24.1",
Expand All @@ -52,11 +56,11 @@ dev = [
"ruff ~= 0.1.6",
"twine ~= 4.0.2",
"types-aiofiles ~= 23.2.0.0",
"types-colorama ~= 0.4.15.11",
"types-psutil ~= 5.9.5.12",
"types-colorama ~= 0.4.15.12",
"types-psutil ~= 5.9.5.17",
]
scrapy = [
"scrapy ~= 2.11.0",
"scrapy >= 2.11.0",
]

[project.urls]
Expand Down