Fix type hint problems for resource clients #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
vdusek
force-pushed
the
fix-typing-in-resource-clients
branch
from
1a4e5f0 to
d69dabc
Compare
fnesveda
approved these changes
Dec 8, 2023
Member
fnesveda
left a comment
fnesveda
left a comment
There was a problem hiding this comment.
Cool! 👍 One day I will rewrite this ugly code to some better abstraction 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
typing_extensions.Selfdoes not work with the annotatedcls, so I had to remove those. However, it's still much lesstype ignores/noqasin the end.Issue
Closes #152