Start triggering Docker image builds on release #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnesveda
added
t-core-services
jirimoravcik
approved these changes
Mar 7, 2023
drobnikj
approved these changes
Mar 8, 2023
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're about to release 1.0.0, we should start including it in our base images.
This will start calling the
repository_dispatchevent in https://github.com/apify/apify-actor-docker/blob/master/.github/workflows/release-python.yml#L13-L14 (and other Python image workflows), and that will start building the images.There's also an accompanying PR in
apify-actor-docker, which has to be merged first.I've also simplified the workflow a bit and rewrote it to not use third-party actions, so that we're not that vulnerable to supply chain attacks, especially since we're passing PATs with high permissions to the actions.