Skip to content

feat: add APIFY_API_PUBLIC_BASE_URL #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2021
Merged

feat: add APIFY_API_PUBLIC_BASE_URL #244

merged 1 commit into from
Aug 16, 2021

Conversation

dragonraid
Copy link
Contributor

Adding APIFY_API_PUBLIC_BASE_URL that will contain public apify cloud's url.

@dragonraid dragonraid self-assigned this Aug 16, 2021
@dragonraid dragonraid requested a review from B4nan August 16, 2021 08:59
@github-actions github-actions bot added this to the 19th Sprint - Platform team milestone Aug 16, 2021
@dragonraid dragonraid requested a review from mtrunkat August 16, 2021 09:00
B4nan
B4nan approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is the one we should let people configure in the SDK, right?

edit: or better say the one that can be changed based on local/dev/prod environments

@dragonraid
Copy link
Contributor Author

so this is the one we should let people configure in the SDK, right?

edit: or better say the one that can be changed based on local/dev/prod environments

This is the public URL of API. With this url customers would be able to access API outside of Apify cloud, unlike API_BASE_URL, which is private.

Does that answer the question?

@dragonraid dragonraid merged commit 3ca39b4 into master Aug 16, 2021
@dragonraid dragonraid deleted the feature/public_base_api branch August 16, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@B4nan B4nan B4nan approved these changes

@mtrunkat mtrunkat Awaiting requested review from mtrunkat

Assignees

@dragonraid dragonraid

Labels

None yet

Projects

None yet

Milestone

19th Sprint - Platform team

Development

Successfully merging this pull request may close these issues.

2 participants

@dragonraid @B4nan