feat(markdown): add GraphQL #319
Conversation
mstephen19
changed the title
|
Also added |
There was a problem hiding this comment.
Would be nice to separate code style changes into separate PR, as its hard to see what you actually changed and what is just code formatting. Also there are some trailing commas missing and lint step fails.
TBH those line breaks look like from prettier. And prettier does quite a poor job in adding line breaks if you ask me :]
packages/markdown/src/marked.ts
Outdated
| if (token.type === 'code' && token.lang) { | ||
| if (token.lang === 'marked-tabs') { | ||
| codeTabsObjectPerIndex[markedTabTokenIndex] = codeTabObjectFromCodeTabMarkdown(token.text); | ||
| codeTabsObjectPerIndex[markedTabTokenIndex] = |
There was a problem hiding this comment.
like this line, why are you breaking it? my guess is prettier and their dumb 80 chars max line length default? :]
There was a problem hiding this comment.
@B4nan yeah sorry that's prettier. I have auto-save when a window is unfocused
There was a problem hiding this comment.
But I have the line length limit to 140
There was a problem hiding this comment.
Using any auto-formatting on projects that does not provide configuration for the tool is... Let's say not very polite :] Even if we want to change code style, it can't be part of such a PR (that should have pretty much one line diff), it needs to be a separate one.
But I have the line length limit to 140
That line had 107 characters 🤷
|
I was going through old, forgotten PRs to clean them up, and I decided to finish this one, since it's tiny but useful. |
3 participants
No description provided.