Skip to content

feat: allow using variables in fields of webhook payload template #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 10, 2023
Merged

feat: allow using variables in fields of webhook payload template #369

merged 8 commits into from
May 10, 2023

Conversation

@valekjo
Copy link
Member

@valekjo valekjo commented Mar 23, 2023 •
edited
Loading

This PR

  • makes parsing slightly more effective (one pass only)
  • adds support for "interpolation" - using {{var:resource.defaultDatasetId}} syntax in strings - ie. adding the possibility to pass it to the input.
  • It's intentionally slightly different mechanism than the parsing, as it does a different thing.

Theoretically it's breaking, I have an idea how to deal with it, just not sure if it's necessary.

@github-actions github-actions bot added this to the 59th sprint - Console team milestone Mar 23, 2023
@github-actions github-actions bot added the t-console Issues with this label are in the ownership of the console team. label Mar 23, 2023
github-actions[bot]
github-actions bot reviewed Mar 23, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@valekjo valekjo changed the title feat: allow using variables in strings in webhook payload template [WIP] feat: allow using variables in strings in webhook payload template Apr 12, 2023
github-actions[bot]
github-actions bot reviewed Apr 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

github-actions[bot]
github-actions bot reviewed Apr 28, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@valekjo valekjo force-pushed the feature/adhoc-allow-using-variables-in-strings branch from 5585004 to eb857da Compare April 28, 2023 13:21
github-actions[bot]
github-actions bot reviewed Apr 28, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

github-actions[bot]
github-actions bot reviewed Apr 28, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@valekjo valekjo added the adhoc Ad-hoc unplanned task added during the sprint. label Apr 28, 2023
@valekjo valekjo changed the title [WIP] feat: allow using variables in strings in webhook payload template feat: allow using variables in fields of webhook payload template Apr 28, 2023
@valekjo valekjo requested review from fnesveda and gippy April 28, 2023 15:28
@valekjo valekjo marked this pull request as ready for review April 28, 2023 15:28
fnesveda
fnesveda requested changes May 2, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments mostly about the tests. Plus we talked live about maybe dropping the var: prefix.

@valekjo
Copy link
Member Author

valekjo commented May 3, 2023

Looks good, just a few comments mostly about the tests. Plus we talked live about maybe dropping the var: prefix.

@fnesveda I've updated the tests, found one bug during the process (how replacement works). And figured out one more reason why I added the var: prefix - so it doesn't break the original behaviour. So instead of var: there is new interpolateStrings option, which just turns on/off the parsing in strings.

@valekjo valekjo requested a review from fnesveda May 3, 2023 11:54
fnesveda
fnesveda approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one tiny typo

@valekjo @fnesveda
Update packages/utilities/src/webhook_payload_template.ts
d11174b 
Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com>
@valekjo valekjo merged commit 005b6cc into master May 10, 2023
@valekjo valekjo deleted the feature/adhoc-allow-using-variables-in-strings branch May 10, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@fnesveda fnesveda fnesveda approved these changes

@gippy gippy gippy approved these changes

Assignees

@valekjo valekjo

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-console Issues with this label are in the ownership of the console team.

Projects

None yet

Milestone

62nd sprint - Console team

Development

Successfully merging this pull request may close these issues.

3 participants

@valekjo @fnesveda @gippy