fix(input_schema): disallow empty enums in input schema
#382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnesveda
added
bug
fnesveda
commented
May 10, 2023
| }; | ||
|
|
||
| expect(() => validateInputSchema(validator, schema)).toThrow( | ||
| 'Input schema is not valid (Field schema.properties.myField.enum.enum must NOT have fewer than 1 items)', |
There was a problem hiding this comment.
I have no idea why there is .enum.enum here, but AJV codebase is such a mess and I don't have the motivation to debug it deeper
drobnikj
approved these changes
May 10, 2023
gippy
approved these changes
May 10, 2023
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow empty enums in input schema, to make schemas like this invalid:
{ // ... properties: { myField: { title: 'Field title', type: 'string', description: 'Some description', enum: [] } } };```