fix: improve createHmacSignatureAsync compatibility with worker-based environments
#573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
Copilot finished reviewing on behalf of
barjin
November 18, 2025 14:11
There was a problem hiding this comment.
Pull Request Overview
This PR fixes compatibility issues with createHmacSignatureAsync in worker-based environments (e.g., Jest tests) by changing from globalThis.require() to direct require() calls. The change addresses environments where globalThis.require() is unavailable while require() still works.
- Replaces conditional
globalThis.require()check with try-catch wrappedrequire()call - Adds fallback to dynamic
import()whenrequire()fails - Wraps both import methods in error handling for better robustness
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vladfrangu
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worker-based environments (e.g.
jesttests) do not have access toglobalThis.require()(while callingrequire()instead works). Deeper investigation shows thattsupdoesn't transpile this in a dangerous way, so we can use this here.Unblocks apify/apify-client-js#782 (tested)
Unblocks failing tests in #570