Use `local_storage_dir` instead of `crawlee_local_storage_dir` and rm relevant type ignores

[vdusek]

Thanks to the Pydantic issue pydantic/pydantic-settings#180 we cannot use the key-word argument local_storage_dir but crawlee_local_storage_dir. We also need to use type ignores there.

Let's rename all the key-word arguments from crawlee_local_storage_dir to local_storage_dir and remove the type ignores once pydantic/pydantic-settings#180 is solved.

[janbuchar]

Strangely enough, Configuration(persist_metadata=False), for example, works as expected - is there anything special about local_storage_dir?

[vdusek]

is there anything special about local_storage_dir?

In the conf test, we set storage dir using env variable:

monkeypatch.setenv('CRAWLEE_STORAGE_DIR', str(tmp_path))

and then override it explicitly via argument:

storage_dir=str(tmp_path)

This setup results in Pydantic's ValidationError, like this:

FAILED tests/unit/_memory_storage_client/test_memory_storage_client.py::test_write_metadata - pydantic_core._pydantic_core.ValidationError: 1 validation error for Configuration
storage_dir
  Extra inputs are not permitted [type=extra_forbidden, input_value='/tmp/pytest-of-vdusek/py...20/test_write_metadata0', input_type=str]
    For further information visit https://errors.pydantic.dev/2.9/v/extra_forbidden

Providing it using the alias:

crawlee_storage_dir=str(tmp_path)

works.

The # type: ignore is there because of mypy pydantic plugin is not perfect.