feat: add ignoreProxyCertificate option for the internal proxy-chain instance#3418
Merged
Conversation
github-actions
Bot
added
the
t-tooling
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the ignoreProxyCertificate option to resolve TLS certificate errors when using HTTPS proxies with self-signed certificates, addressing issue #3369 where BrightData HTTPS proxies were failing with net::ERR_TUNNEL_CONNECTION_FAILED.
Changes:
- Added
ignoreProxyCertificateoption toLaunchContext,BrowserPlugin, and related interfaces - Modified
anonymizeProxySugarto accept and pass throughignoreProxyCertificateto the internalproxy-chainlibrary - Updated all browser plugins (Playwright, Puppeteer, Stagehand) to propagate the option through their proxy handling logic
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/browser-pool/src/launch-context.ts | Added ignoreProxyCertificate field to interface and class with default value of false |
| packages/browser-pool/src/abstract-classes/browser-plugin.ts | Added ignoreProxyCertificate option to BrowserPluginOptions and propagated through createLaunchContext |
| packages/browser-pool/src/anonymize-proxy.ts | Created AnonymizeProxySugarOptions interface and modified logic to invoke proxy chain when ignoreProxyCertificate is set |
| packages/browser-pool/src/playwright/playwright-plugin.ts | Passed ignoreProxyCertificate to anonymizeProxySugar during browser launch |
| packages/browser-pool/src/playwright/playwright-controller.ts | Passed ignoreProxyCertificate to anonymizeProxySugar during incognito page creation |
| packages/browser-pool/src/puppeteer/puppeteer-plugin.ts | Passed ignoreProxyCertificate to anonymizeProxySugar in browser launch and incognito context |
| packages/browser-pool/src/puppeteer/puppeteer-controller.ts | Passed ignoreProxyCertificate to anonymizeProxySugar during context creation |
| packages/browser-crawler/src/internals/browser-launcher.ts | Added ignoreProxyCertificate option to BrowserLaunchContext interface and validation |
| packages/stagehand-crawler/src/internals/stagehand-plugin.ts | Passed ignoreProxyCertificate to anonymizeProxySugar for Stagehand proxy handling |
| packages/memory-storage/src/resource-clients/key-value-store.ts | Unrelated formatting change (collapsed multi-line code to single line) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
Bot
added
the
tested
barjin
changed the title
ignoreProxyCertificate for the internal proxy-chain instanceignoreProxyCertificate option for the internal proxy-chain instance
l2ysho
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ignoreProxyCertificateoption tolaunchContext. When set totrue, this ignores TLS issues with the upstream HTTPS proxy.Closes #3369