feat: Use pnpm config instead of npm config#289
Merged
Conversation
github-actions
Bot
added
the
t-management
B4nan
approved these changes
May 12, 2026
Member
B4nan
left a comment
B4nan
left a comment
There was a problem hiding this comment.
We are blocked in the public repos that still support node 20, and I guess this change would break it there. Which is fine, that's why we version things, but this change needs to be shipped as a major bump (v0.41 is fine).
Member
Author
|
Will they actually break, if they use |
Member
|
Let's see, maybe it will be fine, CI will tell us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PNPM v11 being out, we can use
pnpm configto set up the registry configuration, and with that use"onFail": "error"in thedevEngines.packageManagerconfig in our projects.Let's use
pnpm configin this workflow to allow that. Everyone should update topnpmv11 anyway, so I wouldn't be concerned if this breaks any project.