Skip to content

feat(xml-map): add map of string type serialization/deserialization support#102

Merged
sufyankhanrao merged 5 commits intomainfrom
101-xml-map-adapter-support
Aug 2, 2024
Merged

feat(xml-map): add map of string type serialization/deserialization support#102
sufyankhanrao merged 5 commits intomainfrom
101-xml-map-adapter-support

Conversation

@sufyankhanrao
Copy link
Copy Markdown
Collaborator

@sufyankhanrao sufyankhanrao commented Aug 1, 2024

What

This PR adds support for serialization and deserialization of map of string type properties in the core library. This utility class will be used to annotate and handle map of string type properties in SDK models, ensuring proper serialization and deserialization.

Why

  • To add support for serialization and deserialization of map using the xml adapter

Closes #101

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

This commit adds support for serialization and deserialization of Map properties in the core library. This utility class will be used to annotate and handle Map properties in SDK models, ensuring proper serialization and deserialization.

Closes #101
@sufyankhanrao sufyankhanrao self-assigned this Aug 1, 2024
@sufyankhanrao sufyankhanrao changed the title feat(xml-map): add Map property serialization/deserialization support feat(xml-map): add map property serialization/deserialization support Aug 1, 2024
@sufyankhanrao sufyankhanrao changed the title feat(xml-map): add map property serialization/deserialization support feat(xml-map): add map of string type serialization/deserialization support Aug 1, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 1, 2024

@sufyankhanrao sufyankhanrao merged commit 3b8eab0 into main Aug 2, 2024
@sufyankhanrao sufyankhanrao deleted the 101-xml-map-adapter-support branch August 2, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Map Serialization and Deserialization for XML

2 participants