Skip to content

feat(opt-null-equals): override equals in optional-nullable wrapper#72

Merged
asadali214 merged 5 commits intomainfrom
71-equals-override-optional-nullable
Jun 6, 2023
Merged

feat(opt-null-equals): override equals in optional-nullable wrapper#72
asadali214 merged 5 commits intomainfrom
71-equals-override-optional-nullable

Conversation

@asadali214
Copy link
Copy Markdown
Collaborator

This PR overrides the original equals method for OptionalNullable class and added a new unit test for line coverage.

Closes #71

@asadali214 asadali214 added the enhancement New feature or request label Jun 6, 2023
@asadali214 asadali214 requested a review from sufyankhanrao June 6, 2023 07:49
@asadali214 asadali214 self-assigned this Jun 6, 2023
@asadali214 asadali214 linked an issue Jun 6, 2023 that may be closed by this pull request
@asadali214 asadali214 changed the title feat(opt-null-equals): equals overridden in optional-nullable wrapper feat(opt-null-equals): override equals in optional-nullable wrapper Jun 6, 2023
Comment thread src/main/java/io/apimatic/core/types/OptionalNullable.java
Comment thread src/main/java/io/apimatic/core/types/OptionalNullable.java
Comment thread src/test/java/apimatic/core/type/OptionalNullableTest.java
sufyankhanrao
sufyankhanrao previously approved these changes Jun 6, 2023
Copy link
Copy Markdown
Collaborator

@sufyankhanrao sufyankhanrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asadali214 asadali214 merged commit 7478458 into main Jun 6, 2023
@asadali214 asadali214 deleted the 71-equals-override-optional-nullable branch June 6, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing equals override in core.types.OptionalNullable class

2 participants