feat(logging): update the current logging implementation#94
Merged
sufyankhanrao merged 92 commits intomainfrom Apr 23, 2024
Merged
feat(logging): update the current logging implementation#94sufyankhanrao merged 92 commits intomainfrom
sufyankhanrao merged 92 commits intomainfrom
Conversation
- inject api logger into the global config - add mdc for request and response logging
… into poc-logging
- refactor httpLogger to remove unused logic - move executeAsync request and response logging into AsyncExecutor
… into poc-logging
… into poc-logging
add loggingProvider logger implementation & pass loggerConfig instead of logger instance in global config
fix test cases & rename HttpLogger with SdkLogger
add getLogger in Logger implementations & set setters in SdkLoggingBaseOptions to protected
… into poc-logging
fix lint issues & set query in path to false by default
update testcase for queryParam & fix doc blocks
update logging format
simplify the loggingConfiguration request and resposne body and header
fix method formatting in LoggerUtilities & fix SdkLoggingFactory name and link from README.md
sufyankhanrao
previously approved these changes
Apr 23, 2024
|
sufyankhanrao
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What
This PR updates the current implementation of the logging and logging configuration and some code cleanup changes.
Why
The following changes were made to make the Java logging use structured logging and improve user experience.
Type of change
Select multiple if applicable.
Dependency Change
Updated core-interfaces-java and okhttp-client-adapter package versions
Breaking change
Updated ApiLoggingConfiguration
Checklist