Skip to content

fix(auth-query-params): include auth query params in request#96

Merged
sufyankhanrao merged 5 commits intomainfrom
95-honor-auth-query-params
Apr 23, 2024
Merged

fix(auth-query-params): include auth query params in request#96
sufyankhanrao merged 5 commits intomainfrom
95-honor-auth-query-params

Conversation

@sufyankhanrao
Copy link
Copy Markdown
Collaborator

What

This PR fixes the problem of not including auth query parameters in the Api request. Now request builder makes sure to include the query params specific to auth.

Why

  • To fix a bug that users may encounter with query auth parameters

Closes #95

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

This commit fixes the problem of not including auth query parameters in the Api request. Now request builder makes sure to include the query params specific to auth.

Closes #95
@sufyankhanrao sufyankhanrao self-assigned this Apr 23, 2024
Copy link
Copy Markdown
Contributor

@hamzamahmood hamzamahmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sufyankhanrao sufyankhanrao merged commit 1e559b7 into main Apr 23, 2024
@sufyankhanrao sufyankhanrao deleted the 95-honor-auth-query-params branch April 23, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Honor auth query params while building the Api request

2 participants