Skip to content

fix(bool-serialization): bool value serialization in query and form#46

Merged
sufyankhanrao merged 1 commit intomainfrom
45-fix-form-query-bool-serialization
Oct 18, 2023
Merged

fix(bool-serialization): bool value serialization in query and form#46
sufyankhanrao merged 1 commit intomainfrom
45-fix-form-query-bool-serialization

Conversation

@sufyankhanrao
Copy link
Copy Markdown
Collaborator

What

This PR serializes the boolean value from pascal case to lower case in query and form parameters. It was pascal case due to the native boolean value. During serialization, the boolean value is being transformed into lower case.

Why

Although the query parameter values are case insensitive, we need to make sure that the serialization across our tooling remains the same across all langs.

closes #45

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

This commit serializes the boolean value from pascal case to lower case in query and form parameters. It was pascal case due to the native boolean value. During serialization, the boolean value is being transformed into lower case.

closes #45
@sufyankhanrao sufyankhanrao added the bug Something isn't working label Oct 18, 2023
@sufyankhanrao sufyankhanrao self-assigned this Oct 18, 2023
@sufyankhanrao sufyankhanrao merged commit b6a84b8 into main Oct 18, 2023
@sufyankhanrao sufyankhanrao deleted the 45-fix-form-query-bool-serialization branch October 18, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prefer boolean value serialization to lower case instead of pascal case

2 participants