Skip to content

fix(auth-utility): handle runtime exception in base64 encoding utility#56

Merged
sufyankhanrao merged 1 commit intomainfrom
55-fix-exception-in-auth-credentials-encoding
Apr 19, 2024
Merged

fix(auth-utility): handle runtime exception in base64 encoding utility#56
sufyankhanrao merged 1 commit intomainfrom
55-fix-exception-in-auth-credentials-encoding

Conversation

@sufyankhanrao
Copy link
Copy Markdown
Collaborator

What

This PR handles the exception when the provided props are an array of None items because when any of the item is None the delimiter.join throws an exception because it expects the str instances.

Why

  • To gracefully handle None value scenarios, improving its robustness and preventing potential runtime errors.

Closes #55

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

This commit handles the exception when the provided props are an array of None items because when any of the item is None the `delimiter.join` throws an exception because it expects the str instances.

Closes #55
@sufyankhanrao sufyankhanrao self-assigned this Apr 19, 2024
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sufyankhanrao sufyankhanrao merged commit 45ce9e1 into main Apr 19, 2024
@sufyankhanrao sufyankhanrao deleted the 55-fix-exception-in-auth-credentials-encoding branch April 19, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add handling for provided None props in get_base64_encoded_value utility

2 participants