fix: applies isEnabled condition to parse_ini_file function call#48
Merged
asadali214 merged 2 commits intomasterfrom Mar 15, 2024
Merged
fix: applies isEnabled condition to parse_ini_file function call#48asadali214 merged 2 commits intomasterfrom
asadali214 merged 2 commits intomasterfrom
Conversation
|
sufyankhanrao
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What
This PR adds a condition to calling
parse_ini_file(), by checking if it doesn't exist in the disabled functions listWhy
The disable_functions list in php.ini might contain parse_ini_file function call, as it parses the
.inifile which tends to contain sensitive information apart from the required configuration.Closes #47
Type of change
Select multiple if applicable.
Dependency Change
N/A
Breaking change
This PR does not introduce any breaking changes
Testing
I have tested this change by adding
parse_ini_fileto the disable_functions option in php.ini fileChecklist