Skip to content

feat: support for mapping inner nullable types in arrays#52

Merged
asadali214 merged 2 commits intomasterfrom
51-inner-nullable-array-types
Jun 11, 2024
Merged

feat: support for mapping inner nullable types in arrays#52
asadali214 merged 2 commits intomasterfrom
51-inner-nullable-array-types

Conversation

@asadali214
Copy link
Copy Markdown
Collaborator

What

This PR adds the support for mapping the inner nullable types in array types in responses

Why

There were few types that we were missing the mapping support, we were required to implement its support

Closes #51

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

N/A

Breaking change

N/A

Testing

Unit tests were added to test this feature's implementation

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@asadali214 asadali214 requested a review from sufyankhanrao June 11, 2024 05:48
@asadali214 asadali214 self-assigned this Jun 11, 2024
Copy link
Copy Markdown

@sufyankhanrao sufyankhanrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above mentioned comments need your attention.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@asadali214 asadali214 requested a review from sufyankhanrao June 11, 2024 11:13
Copy link
Copy Markdown

@sufyankhanrao sufyankhanrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asadali214 asadali214 merged commit 407b455 into master Jun 11, 2024
@asadali214 asadali214 deleted the 51-inner-nullable-array-types branch June 11, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for mapping via types like array<string>

2 participants