Hello Hooks #93
Merged
Hello Hooks #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent of these changes is to get `@apollo/react-hooks` in place, so we'll avoid having to update to use emotion v10 (since it was significantly re-written https://emotion.sh/docs/migrating-to-emotion-10).
peggyrayzis
suggested changes
Aug 5, 2019
There was a problem hiding this comment.
Two minor questions, but overall this is incredible!! I love how much simpler the React tree becomes when you remove all the false hierarchy created by the component API. 🎉 Thanks for achieving the stretch goal and knocking this out!
One suggestion - we should point users to this PR in the migration guide. Let's hold off on merging first until we can upgrade from the beta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
react-apolloand the render prop components with@apollo/react-hooks. I've made a few additional changes at the same time, like updating project dependencies (excluding emotion) and fixing tests that were failing with recent versions ofapollo-client.