Skip to content

Conversation

@greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

apollo-client just published its new version 0.4.19.

State Failing tests 🚨
Dependency apollo-client
New version 0.4.19
Type devDependency

This version is covered by your current version range and after updating it in your project the build went from success to failure.

As apollo-client is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? ⚡ greenkeeper upgrade

@kamilkisiela
Copy link
Member

@stubailo Why is chai typings needed here, I don't know... I'm not sure but probably somehow every file listed below contains something like /// <reference types="chai" />.

node_modules/apollo-client/ObservableQuery.d.ts(1,1): error TS2688: Cannot find type definition file for 'chai'.
node_modules/apollo-client/QueryManager.d.ts(3,1): error TS2688: Cannot find type definition file for 'chai'.
node_modules/apollo-client/actions.d.ts(3,1): error TS2688: Cannot find type definition file for 'chai'.
node_modules/apollo-client/data/extensions.d.ts(1,1): error TS2688: Cannot find type definition file for 'chai'.
node_modules/apollo-client/data/mutationResults.d.ts(2,1): error TS2688: Cannot find type definition file for 'chai'.
node_modules/apollo-client/data/readFromStore.d.ts(2,1): error TS2688: Cannot find type definition file for 'chai'.
node_modules/apollo-client/data/writeToStore.d.ts(1,1): error TS2688: Cannot find type definition file for 'chai'.
node_modules/apollo-client/index.d.ts(2,1): error TS2688: Cannot find type definition file for 'chai'.
node_modules/apollo-client/mutations/store.d.ts(1,1): error TS2688: Cannot find type definition file for 'chai'.
node_modules/apollo-client/networkInterface.d.ts(2,1): error TS2688: Cannot find type definition file for 'chai'.
node_modules/apollo-client/queries/store.d.ts(1,1): error TS2688: Cannot find type definition file for 'chai'.
node_modules/apollo-client/watchQueryOptions.d.ts(2,1): error TS2688: Cannot find type definition file for 'chai'.

@stubailo
Copy link
Contributor

That's super weird... we probably have those in the tests, but I don't know how they would end up in the final definitions. Could you take a look? Maybe it's something simple I just don't get.

@kamilkisiela kamilkisiela deleted the greenkeeper-apollo-client-0.4.19 branch October 3, 2016 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants