Skip to content

Conversation

@BernhardRode
Copy link

Hi,
i've splitted up the hello world example into a server and a client package.

I think it is easier to maintain. And starters might get confused by the mixed implementation.

Do you like the idea? If yes, I'd love to add more features.

@apollo-cla
Copy link

@BernhardRode: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@BernhardRode
Copy link
Author

@meteor-bot I signed it 👍🏼

@kamilkisiela
Copy link
Member

kamilkisiela commented Dec 22, 2016

Hi @BernhardRode

That's amazing! Thank you sooo much!

We want to know if an app that uses AoT and tree-shaking compiles without any issue so use this example to test it out in Travis CI.

Could you update those lines?

https://github.com/apollostack/angular2-apollo/blob/master/.travis.yml#L14
https://github.com/apollostack/angular2-apollo/blob/master/.travis.yml#L27
https://github.com/apollostack/angular2-apollo/blob/master/.travis.yml#L31
https://github.com/apollostack/angular2-apollo/blob/master/.travis.yml#L36

@BernhardRode
Copy link
Author

BernhardRode commented Dec 27, 2016

I've adapted the travis ci, but i had to disable the examples' unit tests (chrome in ci etc. is hard) rest seems to work though.

I'll try to make the examples somewhat more usable over the next couple of days.

Thought about some kind of simple angular graphiql thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants