Skip to content

Conversation

@Siyfion
Copy link
Contributor

@Siyfion Siyfion commented Nov 29, 2016

Also updated the dependency to the latest release of graphql.

Also updated the dependency to the latest release of `graphql`.
@helfer
Copy link
Contributor

helfer commented Nov 29, 2016

I think with npm 3 you also have to make it a devDependency to make sure it gets installed for the tests.

@Siyfion
Copy link
Contributor Author

Siyfion commented Nov 29, 2016

That would explain why one environment fails and the other succeeds!

@Siyfion
Copy link
Contributor Author

Siyfion commented Nov 29, 2016

@helfer There you go, that should do it 👍

@helfer
Copy link
Contributor

helfer commented Nov 29, 2016

@Siyfion can we make the peer dependency accept a range like in graphql-tools? That way this change can be completely non-breaking.

@Siyfion
Copy link
Contributor Author

Siyfion commented Nov 29, 2016

@helfer Shall I leave the minimum on 0.7.x (previous dependency) or .5 / .6 like graphql-tools?

EDIT: Looking back I can see it did support v0.6.x at one point, but v0.5.x seems completely untested (so I've gone with 0.6.0 upwards).

@helfer
Copy link
Contributor

helfer commented Nov 29, 2016

Minimum should be what we had before, because I don't know if it will work with 0.6

@Siyfion
Copy link
Contributor Author

Siyfion commented Nov 29, 2016

Ah okay... 0.7.0 minimum it is!

@helfer
Copy link
Contributor

helfer commented Nov 29, 2016

@Siyfion thanks, awesome! I'll release a new version in the next few hours.

@helfer helfer merged commit 848b107 into apollographql:master Nov 29, 2016
@helfer
Copy link
Contributor

helfer commented Nov 29, 2016

nvm, I already published it 😁

@Siyfion Siyfion deleted the patch-1 branch November 29, 2016 17:16
@Siyfion
Copy link
Contributor Author

Siyfion commented Nov 29, 2016

Awesome! Thanks for the help @helfer!

@Urigo
Copy link
Contributor

Urigo commented Nov 29, 2016

#23

@dotansimha
Copy link
Contributor

Awesome!! Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants