-
Notifications
You must be signed in to change notification settings - Fork 133
Moved graphql to a peer-dependency #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also updated the dependency to the latest release of `graphql`.
|
I think with npm 3 you also have to make it a devDependency to make sure it gets installed for the tests. |
|
That would explain why one environment fails and the other succeeds! |
|
@helfer There you go, that should do it 👍 |
|
@Siyfion can we make the peer dependency accept a range like in graphql-tools? That way this change can be completely non-breaking. |
|
@helfer Shall I leave the minimum on 0.7.x (previous dependency) or .5 / .6 like EDIT: Looking back I can see it did support v0.6.x at one point, but v0.5.x seems completely untested (so I've gone with |
|
Minimum should be what we had before, because I don't know if it will work with 0.6 |
|
Ah okay... |
|
@Siyfion thanks, awesome! I'll release a new version in the next few hours. |
|
nvm, I already published it 😁 |
|
Awesome! Thanks for the help @helfer! |
|
Awesome!! Thanks!! |
Also updated the dependency to the latest release of
graphql.