Make filter function reflect example #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct me if I'm wrong, but it looks like the argument to comentAdded in the subscription (line 37) is called repoName, and in the example publish call (line 57), you give the comment the attribute repoFullName. I made the subscription filter function reflect this naming.
Contributor
|
I'm pretty sure this is working code that I took from GitHunt. Basically, the comment that comes in as the root value is the database object, which uses snake case. It's a bit of an awkward situation that we've seen in many GraphQL APIs. |
Author
|
Ok that makes sense. I thought the setup functions were run after the revolver for the comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct me if I'm wrong, but it looks like the argument to comentAdded in the subscription (line 37) is called repoName, and in the example publish call (line 57), you give the comment the attribute repoFullName. I made the subscription filter function reflect this naming.