Merged
Conversation
dpeckett
changed the title
theRealWardo
approved these changes
Dec 3, 2024
Member
theRealWardo
left a comment
theRealWardo
left a comment
There was a problem hiding this comment.
thanks for this. I am happy to not have to go look up these commands in my bash history again 😅
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | ||
|
|
||
| // Config is the Schema for the Apoxy Backplane configuration. | ||
| type Config struct { |
Member
There was a problem hiding this comment.
was this just for testing? I am guessing it was and it can be deleted before merge?
dilyevsky
reviewed
Dec 3, 2024
| type Config struct { | ||
| metav1.TypeMeta `json:",inline"` | ||
|
|
||
| Spec ConfigSpec `json:"spec,omitempty"` |
Contributor
There was a problem hiding this comment.
I think we don't need to have a Spec field here since it's not an actual API object so we don't need to follow this convention here and just drop all the settings in top level similar to this: https://github.com/kubernetes/kubelet/blob/c6be68c24f917323135cecc3ac03394d81a7f048/config/v1beta1/types.go#L89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for adding some additional configuration types.