[dev] add a supervisor driver for backplane#30
Merged
theRealWardo merged 2 commits intomainfrom Mar 27, 2025
Merged
Conversation
dilyevsky
reviewed
Mar 27, 2025
|
|
||
| // NewKineStorage creates a new kine storage. | ||
| func NewKineStorage(ctx context.Context, dsn string) (rest.StoreFn, error) { | ||
| tmpDir := os.Getenv("KINE_TMPDIR") |
Contributor
There was a problem hiding this comment.
Why just regular os.TempDir no workie?
Member
Author
There was a problem hiding this comment.
it seemed that the default here was throwing an error due to lack of support for unix sockets which is what this does when using that in-memory mode we've configured for dev.
dilyevsky
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.