Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): calculate proper row width for UITableViewStyleInsetGrouped #12419

Merged
merged 8 commits into from Feb 4, 2021
Merged

fix(ios): calculate proper row width for UITableViewStyleInsetGrouped #12419

merged 8 commits into from Feb 4, 2021

Conversation

vijaysingh-axway
Copy link
Contributor

https://jira.appcelerator.org/browse/TIMOB-28325

For table view style UITableViewStyleInsetGrouped, it has left and right margin.

@build build added this to the 10.0.0 milestone Jan 27, 2021
@build build requested a review from a team January 27, 2021 20:28
@build
Copy link
Contributor

build commented Jan 27, 2021 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 15357 tests are passing.
(There are 916 skipped tests not included in that total)

Generated by 🚫 dangerJS against effd9d8

sgtcoolguy
sgtcoolguy reviewed Jan 28, 2021
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look fine. Can we add a test that reproduces/verifies the fix? I assume we can set up a view and do a snapshot image test to verify the text is visible?

@build build added the docs label Feb 2, 2021
@vijaysingh-axway
Copy link
Contributor Author

@sgtcoolguy I added the image matching test case. But if I take @2x image from 'iPad Pro 12.9 inch' and run it against iPhone SE (2nd generation), which is 2x, it has approx 14000 and ~18000 pixel difference in tableview and listview, which I think is a lot. So I allowed that much pixel difference in maxPixelMismatch.

@ssekhri
Copy link

ssekhri commented Feb 3, 2021

FR Passed.
Verified on:
Mac OS: 10.15.4
SDK: 10.0.0.v20210202155554
Appc CLI: 8.1.1
JDK: 11.0.6
Node: 12.16.1
Studio: 6.0.0.202005141803
Xcode: 12.3, 12.2
Device: iPhone 7Plus(v14.0)
Simulator: iPhone 11(v14.3), iPad Pro(v14.3), iPhone 5S(v12.2)

@ewanharris ewanharris merged commit 4488fe2 into tidev:master Feb 4, 2021
@build build mentioned this pull request Feb 4, 2021
Merged
m1ga added a commit to m1ga/titanium_mobile that referenced this pull request Mar 3, 2021
@m1ga @sgtcoolguy
@garymathews @vijaysingh-axway @dependabot-preview @jquick-axway @Topener @ewanharris
update brach (#4)
e97cee7 
* refactor(js): create a common kernel/bootstrap

* docs: add details on common folder contents

* build: output a kernel/bootstrap rollup bundle

* split ti.main and ti.kernel bundling

* refactor(ios): use a bootstrap JS file before loading ti.main.js

* fix(ios): implement Ti.Blob binary toString natively

* docs: add notes about the workflow for android startup

* refactor(android): move kroll.js to common

* begin effort to unify the startup/code between platforms
* use split bundling methods to produce proper parts in proper build stages
* don't include ti.kernel.js for Android, as it gets baked into C code

* refactor(android): define Ti.Android.currentService in Module.runModule

* removes the need to pass around context objects everywhere
* remove the now-unused AndroidWrapper stuff

* fix(ios): detect when ios has service

* refactor(android): remove unused moduleContexts

* refactor(android): move most js ti extensions to common

* fix(android): override global.L behavior for non-string default values

match Ti.Local.getString in returning key for non-string default values supplied

* fix(android): fix Ti.Blob.arrayBuffer definition

* feat(ios): add KrollPromise to expose ES6 promises natively

* fix(ios): implement Ti.Blob.arrayBuffer natively

* fix(android): explicitly define Ti.Android.currentService to be null when not a service

* build: wipe tmp dir on clean

* docs: remove outdated test override README

* chore(android): update V8 to 8.7.220.31 (tidev#12384)

compile using c++14

Fixes TIMOB-28314

* fix(ios): set parent view controller for detached view controllers (tidev#12233)

* set parent for UITabController, UINavigationController, AVPlayerViewController
* fixed memory leak in listview and tableview
* remove AVPlayerViewController from parent

Fixes TIMOB-28209, TIMOB-27865

* fix(android): amend method to obtain view in releaseViews() (tidev#12386)

* build(deps-dev): bump commitizen from 4.2.2 to 4.2.3

Bumps [commitizen](https://github.com/commitizen/cz-cli) from 4.2.2 to 4.2.3.
- [Release notes](https://github.com/commitizen/cz-cli/releases)
- [Commits](commitizen/cz-cli@v4.2.2...v4.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump husky from 4.3.7 to 4.3.8

Bumps [husky](https://github.com/typicode/husky) from 4.3.7 to 4.3.8.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v4.3.7...v4.3.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump eslint from 7.17.0 to 7.18.0

Bumps [eslint](https://github.com/eslint/eslint) from 7.17.0 to 7.18.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.17.0...v7.18.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump @rollup/plugin-node-resolve from 11.0.1 to 11.1.0

Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins) from 11.0.1 to 11.1.0.
- [Release notes](https://github.com/rollup/plugins/releases)
- [Commits](rollup/plugins@commonjs-v11.0.1...commonjs-v11.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump rollup from 2.36.1 to 2.37.0

Bumps [rollup](https://github.com/rollup/rollup) from 2.36.1 to 2.37.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.36.1...v2.37.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* feat(android): implement list and table editable and moveable functionality

* docs(android): update documentation for editable and moveable functionality

* feat(android): display drag handle for movable rows

* fix(android): address minor memory leak

* fix(android): add elevation and support transparent backgrounds

* fix(android): use parent background when row is transparent

* fix(android): fire move event after movement

* fix(android): amend getBackground() to ignore transparent backgrounds

* fix(android): include type property in events

* fix(android): implement missing scroll events for ListView and TableView

* fix(android): obtain bindId for child templates

* fix(android): onFling callback return

* fix(android): implement old scrolling event behaviour

* fix(android): amend scrollend event fire condition

* fix(android): include totalItemCount and visibleItemCount properties

* build(deps-dev): bump core-js from 3.8.2 to 3.8.3

Bumps [core-js](https://github.com/zloirock/core-js) from 3.8.2 to 3.8.3.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](zloirock/core-js@v3.8.2...v3.8.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* fix(android): decimal comma TextField handling

Fixes TIMOB-28312

* build(deps): bump fs-extra from 9.0.1 to 9.1.0

Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra) from 9.0.1 to 9.1.0.
- [Release notes](https://github.com/jprichardson/node-fs-extra/releases)
- [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md)
- [Commits](jprichardson/node-fs-extra@9.0.1...9.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* fix(android): optimize table and list view updates (tidev#12363)

* sync for thread safety
* amend table fireEvent
* revert to basic optimization
* reduce cache size
* validate first visible view
*  amend activity validation
* allow marker to fire on partially visible rows
* implement noresults event for ListView

Fixes TIMOB-28294, TIMOB-28308

* fix(ios): set statusbar height to top of safearea view (tidev#12402)

Fixes TIMOB-28323

* build(deps-dev): bump dateformat from 4.4.1 to 4.4.2

Bumps [dateformat](https://github.com/felixge/node-dateformat) from 4.4.1 to 4.4.2.
- [Release notes](https://github.com/felixge/node-dateformat/releases)
- [Commits](felixge/node-dateformat@v4.4.1...v4.4.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* chore(ios): update facebook to 10.0.0 (tidev#12412)

Fixes MOD-2872

* build(deps-dev): bump dateformat from 4.4.2 to 4.5.0

Bumps [dateformat](https://github.com/felixge/node-dateformat) from 4.4.2 to 4.5.0.
- [Release notes](https://github.com/felixge/node-dateformat/releases)
- [Commits](felixge/node-dateformat@v4.4.2...v4.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump rollup from 2.37.0 to 2.38.0

Bumps [rollup](https://github.com/rollup/rollup) from 2.37.0 to 2.38.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.37.0...v2.38.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* chore(android): update ti.facebook to 11.0.2

* fix(ios): expose KrollPromise as part of TitaniumKit

* refactor(ios): add rejectWithErrorMessage method for KrollPromise

* build: add script to find candidate methods for returning Promise

* fix(ios): convert JSValue* to JSValueRef directly

* fix(ios): convert KrollPromise to JSValueRef for return types of old proxies

* fix(ios): have KrollPromise static methods return instancetype, not JSValue*

* refactor(ios): add method to expose current JSContext for TiProxy instances

* fix(ios): make JSValue nonatomic property, retain it under the hood, handle exception in creation

* fix(ios): autorelease Ti.Blob#arrayBuffer() Promise

* fix(ios): make KrollPromise no-op under covers when KrollFinalizer is running to avoid crash

* when finalizing don't even try to generate error object from context

* fix(android): reject promise with Error in MediaModule

* feat(android): have Ti.Database.DB.executeAsync return a Promise

* feat(ios): have Ti.Database.DB.executeAsync return a Promise

* docs(api): note Ti.Database.DB.executeAsync returns a Promise

* test: add promise tests for Ti.Database.DB.executeAsync

* feat(ios): have Ti.Database.DB.executeAllAsync return a Promise

* test: add promise tests for Ti.Database.DB.executeAllAsync

* feat(android): have Ti.Database.DB.executeAllAsync return a Promise

* docs(api): note Ti.Database.DB.executeAllAsync method returns a Promise

* test: update Ti.UI.WebView.userAgent test to use new url

* test: try to detect when iOS app soft crashes and end test suite rather than time out

* docs(api): modernize some Ti.UI.ListView examples (tidev#12418)

* build(deps-dev): bump ssri from 8.0.0 to 8.0.1

Bumps [ssri](https://github.com/npm/ssri) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/latest/CHANGELOG.md)
- [Commits](npm/ssri@v8.0.0...v8.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump danger from 10.6.0 to 10.6.1

Bumps [danger](https://github.com/danger/danger-js) from 10.6.0 to 10.6.1.
- [Release notes](https://github.com/danger/danger-js/releases)
- [Changelog](https://github.com/danger/danger-js/blob/master/CHANGELOG.md)
- [Commits](danger/danger-js@10.6.0...10.6.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump rollup from 2.38.0 to 2.38.1

Bumps [rollup](https://github.com/rollup/rollup) from 2.38.0 to 2.38.1.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.38.0...v2.38.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump @rollup/plugin-node-resolve from 11.1.0 to 11.1.1

Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins) from 11.1.0 to 11.1.1.
- [Release notes](https://github.com/rollup/plugins/releases)
- [Commits](rollup/plugins@commonjs-v11.1.0...node-resolve-v11.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump eslint from 7.18.0 to 7.19.0

Bumps [eslint](https://github.com/eslint/eslint) from 7.18.0 to 7.19.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.18.0...v7.19.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump rollup from 2.38.1 to 2.38.3

Bumps [rollup](https://github.com/rollup/rollup) from 2.38.1 to 2.38.3.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.38.1...v2.38.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump @rollup/plugin-babel from 5.2.2 to 5.2.3

Bumps [@rollup/plugin-babel](https://github.com/rollup/plugins) from 5.2.2 to 5.2.3.
- [Release notes](https://github.com/rollup/plugins/releases)
- [Commits](rollup/plugins@babel-v5.2.2...babel-v5.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps): bump clean-css from 4.2.3 to 5.0.1

Bumps [clean-css](https://github.com/jakubpawlowicz/clean-css) from 4.2.3 to 5.0.1.
- [Release notes](https://github.com/jakubpawlowicz/clean-css/releases)
- [Changelog](https://github.com/jakubpawlowicz/clean-css/blob/master/History.md)
- [Commits](clean-css/clean-css@v4.2.3...v5.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump @rollup/plugin-commonjs from 17.0.0 to 17.1.0

Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins) from 17.0.0 to 17.1.0.
- [Release notes](https://github.com/rollup/plugins/releases)
- [Commits](rollup/plugins@commonjs-v17.0.0...commonjs-v17.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump dateformat from 4.5.0 to 4.5.1

Bumps [dateformat](https://github.com/felixge/node-dateformat) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/felixge/node-dateformat/releases)
- [Commits](felixge/node-dateformat@v4.5.0...v4.5.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump rollup from 2.38.3 to 2.38.4

Bumps [rollup](https://github.com/rollup/rollup) from 2.38.3 to 2.38.4.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.38.3...v2.38.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* fix(ios): swift enabling in Objc module should build (tidev#12372)

Fixes TIMOB-28304

* fix(ios): support ti symbols via xcconfig file to work with swift (tidev#12379)

Fixes TIMOB-28297

* fix(android): guard scroll event section data (tidev#12424)

Fixes TIMOB-28330

* fix(android): rgba(int,int,int) parity (tidev#12435)

Fixes TIMOB-28333

* fix(ios): calculate proper row width for UITableViewStyleInsetGrouped (tidev#12419)

Closes TIMOB-28325

Co-authored-by: ssekhri <ssekhri@axway.com>

* build(deps-dev): bump danger from 10.6.1 to 10.6.2

Bumps [danger](https://github.com/danger/danger-js) from 10.6.1 to 10.6.2.
- [Release notes](https://github.com/danger/danger-js/releases)
- [Changelog](https://github.com/danger/danger-js/blob/main/CHANGELOG.md)
- [Commits](danger/danger-js@10.6.1...10.6.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* test(android): add 2.625x density snapshot images

* test(android): add another 2.625x density snapshot image

* test(android): fix/rename snapshot images

* add some missing 2.625x density images
* drop dimensions from filenames

* test: try to use proper suffixes for ios snapshot images

* test(ios): rename snapshot images

* test: modify test to support 1 pixel difference y value for devices with odd y size

* test: always write list of android devices to be used by suite to map device id for adb commands

* test: allow 2 pixel mismatch on Android for circle borderRadius test

* ci(jenkins): don't test on android device for now

* test: generate full test suite for Ti.Media.AudioPlayer

* fix(ios): expose Ti.Media.AudioPlayer.externalPlaybackActive as boolean properly

* test: skip some hanging tests on android 5

* test: add error event listener to audioplayer proxy

* build(deps-dev): bump chai from 4.2.0 to 4.3.0

Bumps [chai](https://github.com/chaijs/chai) from 4.2.0 to 4.3.0.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/master/History.md)
- [Commits](chaijs/chai@4.2.0...4.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump rollup from 2.38.4 to 2.38.5

Bumps [rollup](https://github.com/rollup/rollup) from 2.38.4 to 2.38.5.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.38.4...v2.38.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump lint-staged from 10.5.3 to 10.5.4

Bumps [lint-staged](https://github.com/okonet/lint-staged) from 10.5.3 to 10.5.4.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](lint-staged/lint-staged@v10.5.3...v10.5.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps): bump ejs from 3.1.5 to 3.1.6

Bumps [ejs](https://github.com/mde/ejs) from 3.1.5 to 3.1.6.
- [Release notes](https://github.com/mde/ejs/releases)
- [Changelog](https://github.com/mde/ejs/blob/main/CHANGELOG.md)
- [Commits](mde/ejs@v3.1.5...v3.1.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* test: skip test on macos that intermittently crashes

* test: try to skip proper test that crashes intermittently on macos

* chore(android): update v8 to 8.8.278.15 (tidev#12449)

Fixes TIMOB-28336

* feat(ios): return Promise from Ti.UI.Window.open()/close()

* feat(android): return Promise from Ti.UI.Window.open()

* feat(android): return Promise from Ti.UI.Window.close()

* properly resolve Ti.UI.NavigationWindow.close()
* use constant reference for close event name
* move rejection of closing unopened window up hierarchy so it applies to TabGroup too

* test: verify Ti.UI.Window#open() and #close() returns Promises

* docs(api): document Ti.UI.Window#open() and #close() returning Promises

* refactor(ios): have tab openWindow()/closeWindow() return Promise

* feat(ios): support Ti.UI.NavigationWindow#open()/close() returning Promise

* test: add tests for Ti.UI.NavigationWindow open/close w/ Promise support

* feat(ios): support Ti.UI.TabGroup#open()/close() returning Promise

* test: add tests for Ti.UI.TabGroup open/close w/ Promise support

* fix(ios): explicitly flush KrollPromises created internally and not exposed to JS

* test: use close promise support to clean up Ti.UI.View tests

* chore(ios): removed iOS sdk 12 and 13 macro

* chore(ios): removed iOS sdk 13 macro from TitaniumKit

* chore(ios): remove check for iOS 11

* chore(ios): set minimum ios  version to iOS 11

* fix(ios): fix sytax error

* fix(ios): fixed sdk build issue

* chore(ios): update module templates to set minimum ios 11

* chore(ios): updated APSHTTPClient APSAnalytics and tiverify xcframeworks

* build(deps-dev): bump husky from 4.3.8 to 5.0.9

Bumps [husky](https://github.com/typicode/husky) from 4.3.8 to 5.0.9.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v4.3.8...v5.0.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* test: skip test that intermittently hangs on old Android emulator

* build(deps-dev): fix husky 5 usage

* test: skip some tests on macos CI if not Big Sur, since scale intermittently wrong

* Revert "build(deps-dev): fix husky 5 usage"

This reverts commit 66d04e8.

* build(deps-dev): fix husky 5 usage

* style(js): fix eslint errors

* feat!: set minimum node version to 12.13.0

Closes TIMOB-28343

* ci: use node 12.18.0

* fix: declare i18n function before its usage

* fix(android): amend child event ListView properties (tidev#12456)

* fix(android): amend child event ListView properties

* fix(android): remove duplicate code

* fix(android): prevent duplicate itemclick event

* fix(ios): use supportedInterfaceOrientations of UINavigationController.topViewController instead of UINavigationController (tidev#12459)

Fixes TIMOB-28282

* fix(android): handle encoded WebView url (tidev#12450)

Fixes TIMOB-28341

* build: revert inadvertent bad shebang

* build(changelog): don't discard community commits of fix or feat type

We want these to exist in community credits and the relevant section

* build(deps-dev): bump mocha from 8.2.1 to 8.3.0

Bumps [mocha](https://github.com/mochajs/mocha) from 8.2.1 to 8.3.0.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](mochajs/mocha@v8.2.1...v8.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* fix(android): move buildOnly assignment into pre-validate hook

The parsing of aliases has not been performed by the time config is called so by waiting until
pre-validate we know that the build-only option has been parsed and handled. Changing the previous
check to also check for b will not work because the cli has not determined it as an alias of
--build-only so the value is still undefined

Closes TIMOB-28345

* fix(android)!: remove get/set methods for properties that have normal property access

* fix(android)!: remove auto-generated accessor methods in proxy native code template

* fix(android)!: remove accessor methods for properties

* fix(ios): expose Ti.Network.HTTPClient#getAllResponseHeaders()

* fix(ios)!: begin ripping out automatic getter/setters for properties

* fix(ios)!: don't expose accessors for properties with Obj-c proxy subclassses

* docs(api): explicitly document Ti.Network.HTTPClient#getAllResponseHeaders()

* docs(api): use remoteBackup property access in place of getter/setter method in example

* docs(api): remove bad default values documented for Ti.Platform version properties

* test: invert tests for getters/accessors to ensure they don't exist

* test: fix namespace inconsistencies in tests

* test: remove generic getter/setter test

* feat(android): expose Ti.Media.AudioPlayer.audioSessionId as read-only property

* test: update audioplayer suite for accessor changes

* test: assign to Intent.flags as property, not using setter

* docs(api): fix AudioPlayer docs for accessor changes/deprecations/removals

* fix(android): expose properties for get/set pairs on QuickSettingsService

* docs(api): document QuickSettingsService properties

* fix(android): remove set methods for width/height/center for Views

* fix(android): add back Ti.Media.Sound.setLooping for now

* docs(api): mark Ti.Media.Sound.setLooping and setPaused as deprecated

* docs(api): note Ti.Network.HTTPClient.getAllResponseHeaders() is on Android since 0.8

* fix(android): remove getters for documented properties on RecurrenceRule

* build(deps-dev): bump eslint from 7.19.0 to 7.20.0

Bumps [eslint](https://github.com/eslint/eslint) from 7.19.0 to 7.20.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.19.0...v7.20.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump @rollup/plugin-node-resolve from 11.1.1 to 11.2.0

Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins) from 11.1.1 to 11.2.0.
- [Release notes](https://github.com/rollup/plugins/releases)
- [Commits](rollup/plugins@node-resolve-v11.1.1...node-resolve-v11.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump @rollup/plugin-babel from 5.2.3 to 5.3.0

Bumps [@rollup/plugin-babel](https://github.com/rollup/plugins) from 5.2.3 to 5.3.0.
- [Release notes](https://github.com/rollup/plugins/releases)
- [Commits](rollup/plugins@babel-v5.2.3...babel-v5.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* feat(android): text alignment justify (tidev#12464)

Fixes TIMOB-28348

* fix(android): do not override itemId type (tidev#12468)

Fixes TIMOB-28326

* build(deps-dev): bump rollup from 2.38.5 to 2.39.0

Bumps [rollup](https://github.com/rollup/rollup) from 2.38.5 to 2.39.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.38.5...v2.39.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* chore(ios): remove iOS 12 check

* chore(ios): set minimum ios version to ios 12

* chore(ios): updated module templates to minimum ios 12

* fix(ios): merged switch statment

* chore(ios): cleaned ti.blob.js

* fix(android): add V8Promise constructor with existing pointer value

* fix(android): validate layoutParams (tidev#12472)

Fixes TIMOB-28352

* build: update to husky 5 properly

* feat(ios): support storyboards in module (tidev#12328)

* feat(ios): support storyboards in module

* fix(ios): addressed review comments

* fix(ios): addressed review comment

Co-authored-by: Christopher Williams <chris.a.williams@gmail.com>
Co-authored-by: ssekhri <ssekhri@axway.com>

* build(deps-dev): bump core-js from 3.8.3 to 3.9.0

Bumps [core-js](https://github.com/zloirock/core-js) from 3.8.3 to 3.9.0.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](zloirock/core-js@v3.8.3...v3.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps): bump clean-css from 5.0.1 to 5.1.0

Bumps [clean-css](https://github.com/jakubpawlowicz/clean-css) from 5.0.1 to 5.1.0.
- [Release notes](https://github.com/jakubpawlowicz/clean-css/releases)
- [Changelog](https://github.com/jakubpawlowicz/clean-css/blob/master/History.md)
- [Commits](clean-css/clean-css@v5.0.1...v5.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* feat(android): implement ATTRIBUTE_UNDERLINE_COLOR functionality (tidev#12471)

Fixes TIMOB-24735

* refactor(wepback): recommend installing plugin via appcd pm for appcd 4 and above

Closes TIMOB-28328

* build(deps-dev): bump lockfile-lint from 4.3.7 to 4.6.1

Bumps [lockfile-lint](https://github.com/lirantal/lockfile-lint) from 4.3.7 to 4.6.1.
- [Release notes](https://github.com/lirantal/lockfile-lint/releases)
- [Commits](https://github.com/lirantal/lockfile-lint/compare/lockfile-lint@4.3.7...lockfile-lint@4.6.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump husky from 5.0.9 to 5.1.0

Bumps [husky](https://github.com/typicode/husky) from 5.0.9 to 5.1.0.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v5.0.9...v5.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* feat(ios): return Promises from Ti.Geolocation.getCurrentHeading/Position methods

* fix(ios): call callback on Geolocation#requestTemporaryFullAccuracyAuthorization if missing purpose

* fix(ios): minor fixes for Ti.Geolocation#requestLocationPermissions()

* tweak requestLocationPermissions promise rejection to be Error object
* guard for when no callback supplied
* fix management of callback/promise

* fix(ios): if user supplies no specific auth constant for hasLocationPermissions, assume WHEN_IN_USE

* fix(ios): error code/object for Ti.Geolocation permissions/position

* fix merge of dictionary for authorizationStatus change so object has code/error props
* properly report error getting location when underlying error code is 0
(use code of -1, so success is false)
* clean up Geolocation code, remove unnecessary tempManager

* feat(android): make Geolocation getCurrentHeading/Position return Promises

Also fix underlying bug where second call to getCurrentPosition() never
fired callback/Promise if no 'location' event listeners

* docs(api): note Ti.Geolocation getCurrentHeading/Position methods return Promise

* test: add Ti.Geolocation Promise tests

* getCurrentHeading
* getCurrentPosition
* hasLocationPermissions
* requestLocationPermissions

* test: add Info.plist key/values needed for geolocation on iOS 14 in test app

* test: set sim location for test app

* fix(ios): fire authorization changes even when no callback

* ci(github): add initial Github Action build (tidev#12485)

* add separate docs workflow/build
* build/package for all oses
* archive osx/win32 zipfiles

* build(deps-dev): bump @commitlint/config-conventional

Bumps [@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint) from 11.0.0 to 12.0.0.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/CHANGELOG.md)
- [Commits](conventional-changelog/commitlint@v11.0.0...v12.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump danger from 10.6.2 to 10.6.3

Bumps [danger](https://github.com/danger/danger-js) from 10.6.2 to 10.6.3.
- [Release notes](https://github.com/danger/danger-js/releases)
- [Changelog](https://github.com/danger/danger-js/blob/main/CHANGELOG.md)
- [Commits](danger/danger-js@10.6.2...10.6.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump rollup from 2.39.0 to 2.39.1

Bumps [rollup](https://github.com/rollup/rollup) from 2.39.0 to 2.39.1.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.39.0...v2.39.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump @commitlint/cli from 11.0.0 to 12.0.0

Bumps [@commitlint/cli](https://github.com/conventional-changelog/commitlint) from 11.0.0 to 12.0.0.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/CHANGELOG.md)
- [Commits](conventional-changelog/commitlint@v11.0.0...v12.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump husky from 5.1.0 to 5.1.1

Bumps [husky](https://github.com/typicode/husky) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v5.1.0...v5.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* fix(ios): largeTitleDisplayMode always is not working in iOS 14 (tidev#12490)

Fixes TIMOB-28361

* fix(ios): showSearchBarInNavBar does not work with custom item templates (tidev#12486)

Fixes TIMOB-26913

* fix(android): use C++14 when building native modules

* fix(android): update v8 to 8.8.278.17

* fix(android): set minSdkVersion to 19

* fix(android): update v8 8.8.278.17 integrity

* chore(ios): update modules in SDK

* fix(ios): remove unsupported architectures

* chore(release): bump target to 10.1.0

* build(android): grab v8 library from Github release URL

* build(deps-dev): bump lockfile-lint from 4.6.1 to 4.6.2

Bumps [lockfile-lint](https://github.com/lirantal/lockfile-lint) from 4.6.1 to 4.6.2.
- [Release notes](https://github.com/lirantal/lockfile-lint/releases)
- [Commits](https://github.com/lirantal/lockfile-lint/compare/lockfile-lint@4.6.1...lockfile-lint@4.6.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* feat(android): add Ti.UI.ButtonBar (tidev#12389)

Fixes TIMOB-25954

* refactor(ios): gather resources async, including node_modules

* feat(ios): include project root node_modules folder in app

* fix(ios): modify gathering of npm packages

include peer dependencies optionally, ignore some packages based on package.json

* fix: handle when project has no root package.json

* refactor: move gathering code to common cli/lib dir

* feat(android): add npm packages to android apps

* refactor: extract task to copy resources, fix processed js files

* refactor: move css minification logic to a task

* refactor(ios): make build async AF

* refactor(ios): use copy resources task to copy on ios

* refactor(android): remove timing logs for gathering resources in cli

* refactor(ios): remove timing logs for gathering resources in cli

* test: move package.json to top-level of test app

- handle root-level package.json in test suite in test script
- verify can't load ms devDependency at runtime

* fix: support cjs files in apps equivalent to js files

* test: use mocha from npm in place of old ti-mocha

* use npm 6 lockfile version 1
* use different dev dependency in place of ms, since it's in mocha hierarchy

* test: run test project from it's root as cwd, add babel config to skip a mocha file

* test: fix running Ti.Blob resize image test

- wrap async event listener body in try/catch for ti.blob test
- run on postlayout event
- increase timeout

* test: use this.skip() w/ new mocha on tests to skip based on runtime values

* fix(cli): filepath compatibility with windows

Co-authored-by: Gary Mathews <contact@garymathews.com>

* build(deps-dev): bump @commitlint/config-conventional

Bumps [@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint) from 12.0.0 to 12.0.1.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/CHANGELOG.md)
- [Commits](conventional-changelog/commitlint@v12.0.0...v12.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* ci(github): try to avoid double-builds of pushes to PRs

* build(deps-dev): bump eslint from 7.20.0 to 7.21.0

Bumps [eslint](https://github.com/eslint/eslint) from 7.20.0 to 7.21.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.20.0...v7.21.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump husky from 5.1.1 to 5.1.2

Bumps [husky](https://github.com/typicode/husky) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v5.1.1...v5.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump @commitlint/cli from 12.0.0 to 12.0.1

Bumps [@commitlint/cli](https://github.com/conventional-changelog/commitlint) from 12.0.0 to 12.0.1.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/CHANGELOG.md)
- [Commits](conventional-changelog/commitlint@v12.0.0...v12.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* fix: record output files for process js task

* build(deps-dev): bump husky from 5.1.2 to 5.1.3

Bumps [husky](https://github.com/typicode/husky) from 5.1.2 to 5.1.3.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v5.1.2...v5.1.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump rollup from 2.39.1 to 2.40.0

Bumps [rollup](https://github.com/rollup/rollup) from 2.39.1 to 2.40.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.39.1...v2.40.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* build(deps-dev): bump core-js from 3.9.0 to 3.9.1

Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.9.0 to 3.9.1.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.9.1/packages/core-js)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* fix(android): expose builder property for hyperloop to mark js files not to process

* chore(deps): update appc-tasks to 1.0.3

Co-authored-by: Chris Williams <chris.a.williams@gmail.com>
Co-authored-by: Gary Mathews <contact@garymathews.com>
Co-authored-by: Vijay Vikram Singh <vsingh@axway.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Joshua Quick <jquick@axway.com>
Co-authored-by: Rene Pot <Topener@users.noreply.github.com>
Co-authored-by: ssekhri <ssekhri@axway.com>
Co-authored-by: Ewan Harris <ewanharris93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
docs in-qe-testing 🕵 ios
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @ssekhri @sgtcoolguy @ewanharris