fix(i18n,ui): 修 PR #236 合并后 ja/ko 缺键 + SelectionAsk 启用开关右置#307
Merged
Conversation
PR #236 合并后两处后续修复: 1. ja.ts / ko.ts 缺 PR 引入的 7 个 comboRecord* 键和 1 个 triggers.custom 键,导致 main 的 npm run build 直接 TS 报错。 补齐后 tsc 通过。 2. SelectionAsk 划词追问页:触发快捷键卡片把"右上角状态徽标 + 下方启用按钮"换成与 Style 页一致的右上角 36×20 toggle; 保存历史卡片同步从底部 44×24 开关改成右上角同款 toggle。 抽出 CardHeaderToggle 复用,跟 design_handoff Style 页对齐。
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
PR #236 合并到 main 之后两处后续修复:
Test plan
PR Type
Bug fix, Enhancement
Description
Add missing comboRecord* and triggers.custom keys to ja.ts and ko.ts
Replace SelectionAsk toggle buttons with reusable CardHeaderToggle for UI consistency
Remove legacy enable button and status badge from SelectionAsk page
Diagram Walkthrough
File Walkthrough
ja.ts
Add missing shortcut recording keys to Japanese translationopenless-all/app/src/i18n/ja.ts
localization
ko.ts
Add missing shortcut recording keys to Korean translationopenless-all/app/src/i18n/ko.ts
localization
SelectionAsk.tsx
Refactor SelectionAsk toggles to reusable CardHeaderToggleopenless-all/app/src/pages/SelectionAsk.tsx
component
switches