add Settings, and ignoreUnimportantViews setting #106
Merged
+111
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think that makes sense. One advantage of a general setSettings is people can use the new settings without waiting for java-client to be updated. I don't mind either way. |
Jonahss
added a commit
that referenced
this pull request
Sep 10, 2014
add Settings, and ignoreUnimportantViews setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do people think of this implementation of the new Settings methods?
I see Java as a more strict environment, where users should only really be setting settings which are already specified.
Could make the general SetSetting methods public though... thoughts?