Fixed methods that use dimensions relative to a given WebElement

[BJap]

Half fixed so far. Still WIP

[BJap]

This of course does not cover the edge cases (literally edge) but to program more defensively, one could handle cases such as:

The element is partly off the screen: yOffset becomes Math.min(element height / 2, center to nearest vertical edge)

The element's vertical center is off screen: center is half the distance from the nearest vertical edge to the vertical edge of the element still on screen added or subtracted to that y coordinate and yOffset becomes that distance

[BJap]

I am ready for input, ideas, suggestions, and so on. I still am hesitant to use a hard-coded '100' value and adjust if this creates a negative coordinate for one of the outer points. Still, the if else statement is solid because an element's center cannot be less than '100' distance from both edges of the phone at the same time in worst case. This would be for instance, if the phone were to be rotated sideways and the smallest width has always been 320 points.

[Jonahss]

Couldn't you have a smaller width on an Android Wear device?

[Jonahss]

Ahh I see what you did. I like it. These are convenience methods anyways, and don't have to work in every possible case. You have certainly made them more convenient :)

[Jonahss]

Will merge after I run the test suite.

[BJap]

@Jonahss you're right outside of the iOS infrastructure for sure. I hadn't explored wearables yet on Android to know better haha.

Hopefully more people can use these methods. I did read the documentation but I would love for more people to be able to use them even if it's just for 'quick and dirty'. They are really good methods for sure.

Thanks! btw this is my first open-source contibution. You made this possible 👍 I hope to contribute more as I continue to use this.

[Jonahss]

Congrats!
Will be included in next release, which will be soon!