Skip to content

Conversation

@Jonahss
Copy link
Member

@Jonahss Jonahss commented Sep 25, 2014

I got rid of AndroidContextTest, we only need to test contexts once :)

@Jonahss
Copy link
Member Author

Jonahss commented Sep 25, 2014

@TikhomirovSergey I think #105 is done! what do you think?

@TikhomirovSergey
Copy link
Contributor

I think so.

But my point about AndroidContextTest I have expressed in #105 (please read my last comment). If it is feature I think it should be covered by test. If there is a bug which nobody have reported this test could be removed and bug has to be fixed.

@Jonahss
Copy link
Member Author

Jonahss commented Sep 25, 2014

There's something else we could do. Can be done after this implementation, as a future feature, but maybe we should have AndroidElement and IosElement classes which inherit from MobileElement?
Doesn't make sense to call 'byIosUIAutomation' when you are using android.

Jonahss added a commit that referenced this pull request Sep 25, 2014
moved context tests around, added AppiumDriverTest
@Jonahss Jonahss merged commit b5b481e into appium:interfacesRefactor Sep 25, 2014
@TikhomirovSergey
Copy link
Contributor

There's something else we could do. Can be done after this implementation, as a future feature, but >maybe we should have AndroidElement and IosElement classes which inherit from MobileElement?
Doesn't make sense to call 'byIosUIAutomation' when you are using android.

Yep! It has been done at Jonahss#1. I agree with this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants