Skip to content

chore: Avoid appium-support imports #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2020
Merged

chore: Avoid appium-support imports #108

merged 1 commit into from
Jul 14, 2020

Conversation

@mykola-mokhnach
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach commented Jul 14, 2020 •
edited
Loading

appium-support is big and it adds unnecessary overhead if this module is imported by third-parties

jlipps
jlipps approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any value in publishing each component of appium-support additionally in its own package, the way e.g. lodash does?

@mykola-mokhnach
Copy link
Contributor Author

Is there any value in publishing each component of appium-support additionally in its own package, the way e.g. lodash does?

We should analyze first which parts of is are used where. This could be a good practice though.

@mykola-mokhnach mykola-mokhnach merged commit 75a7e48 into appium:master Jul 14, 2020
@mykola-mokhnach mykola-mokhnach deleted the deps branch July 14, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlipps jlipps jlipps approved these changes

@KazuCocoa KazuCocoa Awaiting requested review from KazuCocoa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mykola-mokhnach @jlipps