Fix functional tests failed #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ki4070ma
commented
May 3, 2019
KazuCocoa
reviewed
May 4, 2019
| data_ret = base64.b64decode(self.driver.pull_file(path)) | ||
|
|
||
| # python2 | ||
| # self.driver.push_file(path, data.encode('base64')) |
There was a problem hiding this comment.
Should Python 2 separates here?
base64.b64encode(b'This is the contents of the file to push to the device.').decode('utf-8')
=> u'VGhpcyBpcyB0aGUgY29udGVudHMgb2YgdGhlIGZpbGUgdG8gcHVzaCB0byB0aGUgZGV2aWNlLg=='
in Python 2
There was a problem hiding this comment.
Now enabled running by both python2 and python3
$python2 appium_tests.py
--
$python3 appium_tests.py
There was a problem hiding this comment.
I misunderstood, I'll check the result also in py2 by its codes.
==
Thanks it works.
ki4070ma
commented
May 4, 2019
ki4070ma
commented
May 4, 2019
KazuCocoa
approved these changes
May 7, 2019
|
这些测试用例目前全不全呢，有没有比较全的安卓自动化测试用例呢。 |
|
@becomemoreandmorepowerful
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified with
Remaining (will be by the next pr)