dns config should have options not opts
#303
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crosbymichael <michael_crosby@apple.com>
jglogan
approved these changes
Sep 29, 2025
This was referenced Oct 1, 2025
jglogan
added a commit
to apple/container
that referenced
this pull request
Oct 1, 2025
- Converts client to work with ExitStatus instead of integer error codes. ## Type of Change - [ ] Bug fix - [ ] New feature - [x] Breaking change (SandboxClient.wait() returns ExitStatus instead of Int32, apple/containerization#300) - [ ] Documentation update ## Motivation and Context Pick up DNS bug fix, update for breaking API change. ## Testing - [x] Tested locally - [x] Added/updated tests (fixed DNS test, using correct `options` now, apple/containerization#303). - [ ] Added/updated docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.