-
Notifications
You must be signed in to change notification settings - Fork 737
Closed
Labels
bugUnexpected behaviour that should be corrected (type)Unexpected behaviour that should be corrected (type)triagedReviewed and examined, release as been assigned if applicable (status)Reviewed and examined, release as been assigned if applicable (status)
Description
The Docstring says:
(2) string:
Verify different input parameters binding with the same `type_domain` are the same data type.
This additional check is done by defining a `type_domains` dictionary in the Operation class
For example:
```
class conv(Operation):
input_spec = InputSpec(
x=TensorInputType(type_domain="T"),
weight=TensorInputType(type_domain="U"),
)
type_domains = {
"T": (types.fp16, types.fp32),
}
```
would verify:
(i) `x` and `weight` are one of the float16 or float32 type.
(ii) `x` and `weight` are the same type.
| (2) string: |
But I think should be changed to:
@@ -251,7 +251,7 @@ class TensorInputType(_InputType):
class conv(Operation):
input_spec = InputSpec(
x=TensorInputType(type_domain="T"),
- weight=TensorInputType(type_domain="U"),
+ weight=TensorInputType(type_domain="T"),
)
type_domains = {YifanShenSZ
Metadata
Metadata
Assignees
Labels
bugUnexpected behaviour that should be corrected (type)Unexpected behaviour that should be corrected (type)triagedReviewed and examined, release as been assigned if applicable (status)Reviewed and examined, release as been assigned if applicable (status)