Add deprecation warnings #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobyRoseman
reviewed
May 15, 2020
Collaborator
TobyRoseman
left a comment
TobyRoseman
left a comment
There was a problem hiding this comment.
@aseemw - Lot of good stuff here. This is a great change. I just have lots of minor comments.
DawerG
reviewed
May 15, 2020
DawerG
reviewed
May 15, 2020
aseemw
force-pushed
the
dev/deprecation_warnings
branch
from
f310986 to
cfac3f2
Compare
DawerG
reviewed
May 16, 2020
DawerG
previously approved these changes
May 16, 2020
address review comments update the warning message in the decorator to work with classes
aseemw
force-pushed
the
dev/deprecation_warnings
branch
from
cfac3f2 to
ca4879d
Compare
1duo
approved these changes
May 18, 2020
bhushan23
pushed a commit
that referenced
this pull request
Aug 17, 2020
address review comments update the warning message in the decorator to work with classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.