Simple prefix compression for GetKeyValuesReply #3076
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the serialization for
VectorRef<KeyValueRef, VecSerStrategy::String>(used by GetKeyValuesReply), to do some simple prefix compression. The max key size allowed fits in a uint16_t, so replace the uint32_t we're currently using for key size with a uint16_t. Use the remaining uint16_t to indicate the length of the prefix borrowed from the previous key. The encoding for a key-value pair now looks like this:If the common prefix length is always zero, then messages are the same size as before.
Calculate the length of the common prefix using a linear scan. On the storage server, for every common byte we scan, we save a memcpy for that byte so I think it ends up being a wash. In the end we're just left with smaller network messages. The client does now need to do some extra memcpy'ing to restore the prefix.