Skip to content

Conversation

@HT154
Copy link
Contributor

@HT154 HT154 commented Nov 13, 2025

No description provided.

@HT154 HT154 force-pushed the github-actions branch 20 times, most recently from a63f38c to d776b11 Compare November 14, 2025 21:54
@HT154 HT154 marked this pull request as ready for review November 14, 2025 21:55
Copy link
Member

@bioball bioball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 42 to 72
name: String
platform: Platform
fixed platformId: String = platform.toLowerCase().replaceAll(" ", "-")
fixed sdk: String =
Map(
"iOS Simulator", "iphonesimulator",
"watchOS Simulator", "watchsimulator",
"tvOS Simulator", "appletvsimulator",
"visionOS Simulator", "xrsimulator",
"Mac Catalyst", "macosx"
)[platform]
hidden destination: String = "platform=\(platform),name=\(name)"
settings: Mapping<String, Any> = new {
["ONLY_ACTIVE_ARCH"] = "YES"
["CODE_SIGNING_REQUIRED"] = "NO"
["CODE_SIGNING_ALLOWED"] = "YES"
["COMPILER_INDEX_STORE_ENABLE"] = "NO"
}
flags: Listing<String> = new {
"-sdk \(sdk)"
"-destination '\(destination)'"
for (k, v in settings) {
"\(k)=\(v)"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] separate all of these properties by an empty line

}
flags: Listing<String> = new {
"-sdk \(sdk)"
"-destination '\(destination)'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"-destination '\(destination)'"
"-destination '\(destination)'"

@HT154 HT154 merged commit fe81a98 into apple:main Nov 14, 2025
@HT154 HT154 deleted the github-actions branch November 14, 2025 23:21
bioball pushed a commit that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants