-
Notifications
You must be signed in to change notification settings - Fork 32
Migrate to GitHub Actions #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a63f38c to
d776b11
Compare
bioball
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| name: String | ||
| platform: Platform | ||
| fixed platformId: String = platform.toLowerCase().replaceAll(" ", "-") | ||
| fixed sdk: String = | ||
| Map( | ||
| "iOS Simulator", "iphonesimulator", | ||
| "watchOS Simulator", "watchsimulator", | ||
| "tvOS Simulator", "appletvsimulator", | ||
| "visionOS Simulator", "xrsimulator", | ||
| "Mac Catalyst", "macosx" | ||
| )[platform] | ||
| hidden destination: String = "platform=\(platform),name=\(name)" | ||
| settings: Mapping<String, Any> = new { | ||
| ["ONLY_ACTIVE_ARCH"] = "YES" | ||
| ["CODE_SIGNING_REQUIRED"] = "NO" | ||
| ["CODE_SIGNING_ALLOWED"] = "YES" | ||
| ["COMPILER_INDEX_STORE_ENABLE"] = "NO" | ||
| } | ||
| flags: Listing<String> = new { | ||
| "-sdk \(sdk)" | ||
| "-destination '\(destination)'" | ||
| for (k, v in settings) { | ||
| "\(k)=\(v)" | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] separate all of these properties by an empty line
.github/index.pkl
Outdated
| } | ||
| flags: Listing<String> = new { | ||
| "-sdk \(sdk)" | ||
| "-destination '\(destination)'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "-destination '\(destination)'" | |
| "-destination '\(destination)'" |
d776b11 to
062ba85
Compare
062ba85 to
bd3b9df
Compare
No description provided.