Implement source location information for pairwise block builders #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phausler
commented
Feb 23, 2022
Package.swift
Outdated
| dependencies: ["AsyncAlgorithms", "AsyncSequenceValidation"]), | ||
| dependencies: ["AsyncAlgorithms", "AsyncSequenceValidation"], | ||
| swiftSettings: [ | ||
| .unsafeFlags(["-Xfrontend", "-enable-experimental-pairwise-build-block"]) |
There was a problem hiding this comment.
This is needed for now until that feature lands. Right now if you want to try out the branch you have to use the latest toolchain download from swift.org.
| AccumulatedInputsWithOperation(inputs: [], operation: operation) | ||
| } | ||
|
|
||
| public static func buildBlock(combining input: String, into accumulated: AccumulatedInputs, file: StaticString = #file, line: UInt = #line) -> AccumulatedInputs { |
There was a problem hiding this comment.
This syntax will eventually be altered slightly but the same concept will be available.
parkera
reviewed
Feb 23, 2022
|
I could reconstitute the output if we wanted as additional diagnostics. |
|
FYI this PR implements the new name |
phausler
force-pushed
the
pr/pairwise_build_block
branch
from
02a0ab4 to
cc05f49
Compare
phausler
commented
Mar 14, 2022
| .unsafeFlags([ | ||
| "-Xfrontend", "-disable-availability-checking" | ||
| "-Xfrontend", "-disable-availability-checking", | ||
| "-Xfrontend", "-enable-experimental-pairwise-build-block" |
There was a problem hiding this comment.
This is now available as of the 3/9 toolchain
kperryua
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for https://forums.swift.org/t/pitch-buildpartialblock-for-result-builders/55561 usage. It allows us to ferry full information of where the failure occurs as a source location; and potentially even string index in that output.
The errors are MUCH easier to identify using this approach because now they can emit directly where the expectation failure occurs.