Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement `NSSet#description` #2037

Merged
merged 4 commits into from Mar 26, 2019

Conversation

Projects
None yet
3 participants
@rikusouda
Copy link
Contributor

rikusouda commented Mar 23, 2019

Because NSSet#description was not implemented.

[Foundation] Implement `NSSet#description`
Because `NSSet#description` was not implemented.
@spevans

This comment has been minimized.

Copy link
Collaborator

spevans commented Mar 23, 2019

@swift-ci test

indent += " "
}
var result = indent + "{(\n"
let cnt = count

This comment has been minimized.

Copy link
@spevans

spevans Mar 23, 2019

Collaborator

Is cnt needed here? It seems to just mirror the value held in count?

This comment has been minimized.

Copy link
@rikusouda

rikusouda Mar 23, 2019

Author Contributor

Thanks!!
I fixed it. 231c8be

Remove variable named `cnt`
For following review
#2037 (comment)
@spevans

This comment has been minimized.

Copy link
Collaborator

spevans commented Mar 23, 2019

@swift-ci test

1 similar comment
@spevans

This comment has been minimized.

Copy link
Collaborator

spevans commented Mar 23, 2019

@swift-ci test

@ikesyo

This comment has been minimized.

Copy link
Collaborator

ikesyo commented Mar 23, 2019

@swift-ci test Linux platform

@rikusouda

This comment has been minimized.

Copy link
Contributor Author

rikusouda commented Mar 23, 2019

Could you start test? 🙇

@spevans

This comment has been minimized.

Copy link
Collaborator

spevans commented Mar 23, 2019

@swift-ci test

1 similar comment
@ikesyo

This comment has been minimized.

Copy link
Collaborator

ikesyo commented Mar 24, 2019

@swift-ci test

@rikusouda

This comment has been minimized.

Copy link
Contributor Author

rikusouda commented Mar 24, 2019

Fixed it again

@ikesyo

This comment has been minimized.

Copy link
Collaborator

ikesyo commented Mar 24, 2019

@swift-ci Please test

1 similar comment
@spevans

This comment has been minimized.

Copy link
Collaborator

spevans commented Mar 24, 2019

@swift-ci Please test

@spevans

This comment has been minimized.

Copy link
Collaborator

spevans commented Mar 24, 2019

FYI, the test failures are not related to your changes, they look to be due to issues in one of the other repositories.

@spevans

This comment has been minimized.

Copy link
Collaborator

spevans commented Mar 24, 2019

@swift-ci test linux

@rikusouda

This comment has been minimized.

Copy link
Contributor Author

rikusouda commented Mar 24, 2019

FYI, the test failures are not related to your changes, they look to be due to issues in one of the other repositories.

Thanks for your information! I got it.

@rikusouda

This comment has been minimized.

Copy link
Contributor Author

rikusouda commented Mar 26, 2019

Is there any action I should to do?

@ikesyo

This comment has been minimized.

Copy link
Collaborator

ikesyo commented Mar 26, 2019

@swift-ci Please test Linux platform

@ikesyo ikesyo changed the title [Foundation] Implement `NSSet#description` Implement `NSSet#description` Mar 26, 2019

@ikesyo

ikesyo approved these changes Mar 26, 2019

@ikesyo ikesyo merged commit 7e390f3 into apple:master Mar 26, 2019

2 checks passed

Swift Test Linux Platform
Details
Swift Test macOS Platform
Details
@ikesyo

This comment has been minimized.

Copy link
Collaborator

ikesyo commented Mar 26, 2019

Thanks for working on it!

@rikusouda

This comment has been minimized.

Copy link
Contributor Author

rikusouda commented Mar 26, 2019

Thanks a lot

@rikusouda rikusouda deleted the rikusouda:nsset_description branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.