Add testing interfaces for the stream and writer of the NIOAsyncChannel
#2488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
approved these changes
Jul 31, 2023
FranzBusch
force-pushed
the
fb-testing-interfaces-async-channel
branch
from
777d218 to
0bedccc
Compare
gjcairo
approved these changes
Jul 31, 2023
FranzBusch
force-pushed
the
fb-testing-interfaces-async-channel
branch
from
0bedccc to
1ff97ed
Compare
…nel` # Motivation When using the `NIOAsyncChannel` to build higher level abstractions it is hard to test right now since one cannot drive the `NIOAsyncChannelInputStream` nor the `NIOAsyncChannelOutputWriter`. # Modification This PR adds new factory methods to both of those types which allow to either drive the input stream or record the outputs written to the output writer. # Result One can now successfully test their code written on top of the input stream and output writer.
FranzBusch
force-pushed
the
fb-testing-interfaces-async-channel
branch
from
1ff97ed to
6eb7c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using the
NIOAsyncChannelto build higher level abstractions it is hard to test right now since one cannot drive theNIOAsyncChannelInputStreamnor theNIOAsyncChannelOutputWriter.Modification
This PR adds new factory methods to both of those types which allow to either drive the input stream or record the outputs written to the output writer.
Result
One can now successfully test their code written on top of the input stream and output writer.