add arm64 support for M1 Mac #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elseif("${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "aarch64") | ||
| set("${result_var_name}" "aarch64" PARENT_SCOPE) | ||
| elseif ("${CMAKE_SYSTEM_PROCESSOR}" MATCHES "AArch64|aarch64|arm64") | ||
| if(CMAKE_SYSTEM_NAME MATCHES Darwin) |
Member
There was a problem hiding this comment.
I am not a CMake expert; should CMAKE_SYSTEM_NAME be string-substituted here (like ${CMAKE_SYSTEM_PROCESSOR} is?
Contributor
Author
There was a problem hiding this comment.
this cmake code is just copied from swift-atomics/cmake/modules/SwiftSupport.cmake.
or I can update it to STREQUAL
Member
There was a problem hiding this comment.
Ok. I'll take this as-is, then, and if Saleem or Michael have any opinions on how it could be better we'll do that separately.
Contributor
There was a problem hiding this comment.
This matches the other projects, and is fine. It avoids some of the noise by not dereferencing which is common.
Member
Member
|
@swift-ci test |
stephentyrone
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it will fail if it is built on M1 Mac, so add arm64 for M1 Mac