Syscall mock testing #1
Conversation
Adds mocking and tracing infrastructure, test infrastructure, and trace-based tests.
| guard 0 == pthread_key_create(&raw, releaseObject) else { | ||
| fatalError("Unable to create key") | ||
| } | ||
| // TODO: All threads are sharing the same object; this is wrong |
There was a problem hiding this comment.
@lorentey this is where I'm probably using TLS wrong.
There was a problem hiding this comment.
Oh, this looks doable -- the key thing is that you only want to create the key here, but leave its value NULL. The setspecific call needs to be moved within withMockingEnabled -- the mocking driver must only be set on threads that want to mock, and the wrappers need to bypass all mocking if they see getspecific return NULL.
There was a problem hiding this comment.
Beware of nested withMockingEnabled invocations, it's easy to accidentally overwrite an active pointer & leak memory (setspecific doesn't run the destructor on the previous value -- so saving & restoring will work)
There was a problem hiding this comment.
withMockingEnabled does swap out the state, but I think we can simplify it by having it swap out a reference. Good idea, and we should also add a test for that.
|
For some reason Github isn't recognizing my latest pushes. Closing and re-opening |
2 participants
Adds mocking and tracing infrastructure, test
infrastructure, and trace-based tests.
TODO: Linux testing.