Skip to content

Conversation

@amraboelela
Copy link
Contributor

No description provided.

@milseman
Copy link
Member

milseman commented Jun 1, 2017

@amraboelela could you give an explanation in the commit message? That way when inspecting git blame in the future, it's more understandable.

@amraboelela
Copy link
Contributor Author

Do I need to create a new PR?
And what should I say in the commit message?

@amraboelela
Copy link
Contributor Author

How about now? :)

@CodaFi
Copy link
Contributor

CodaFi commented Jun 1, 2017

You can squash these (I recommend git rebase -i) down into one commit, then use git commit --amend to rewrite the commit message with the more informative message instead of adding empty commits

@amraboelela amraboelela closed this Jun 1, 2017
@amraboelela amraboelela deleted the remove-android-define branch June 1, 2017 23:33
@milseman
Copy link
Member

milseman commented Jun 1, 2017

I can squash on merge as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants