[index/build] Upstream indexing while building changes #10716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch upstreams previously AppleInternal changes for indexing while building.
Contributor
Author
|
@swift-ci Please smoke test |
akyrtzi
reviewed
Jun 30, 2017
| TYPE("tbd", TBD, "tbd", "") | ||
| TYPE("module-trace", ModuleTrace, "trace.json", "") | ||
|
|
||
| // BEGIN APPLE-ONLY OUTPUT TYPES |
Contributor
There was a problem hiding this comment.
I think the APPLE-ONLY comments can be removed.
akyrtzi
reviewed
Jun 30, 2017
| OI.CompilerMode = OutputInfo::Mode::SingleCompile; | ||
| break; | ||
|
|
||
| // BEGIN APPLE-ONLY OUTPUT ACTIONS |
akyrtzi
reviewed
Jun 30, 2017
| FrontendModeOption = "-emit-tbd"; | ||
| break; | ||
|
|
||
| // BEGIN APPLE-ONLY OUTPUT TYPES |
akyrtzi
reviewed
Jun 30, 2017
Contributor
akyrtzi
left a comment
akyrtzi
left a comment
There was a problem hiding this comment.
Other than the APPLE-ONLY comments, LGTM.
modocache
added a commit
to modocache/swift
that referenced
this pull request
Oct 4, 2017
A post-commit reviewer on swiftlang#10716 asked that the comments be removed. Remove them, as they're no longer demarcating code that is internal to Apple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch upstreams previously AppleInternal changes for
indexing while building.