[SourceKit] Add local variables to structure (SR-5057)#11431
Merged
nkcsgexi merged 1 commit intoswiftlang:masterfrom Aug 11, 2017
Merged
[SourceKit] Add local variables to structure (SR-5057)#11431nkcsgexi merged 1 commit intoswiftlang:masterfrom
nkcsgexi merged 1 commit intoswiftlang:masterfrom
Conversation
Contributor
|
Thank you for working on SourceKit 🙌🏻 |
Member
|
@marcelofabri Thanks! |
Member
|
@swift-ci test macOS |
nkcsgexi
approved these changes
Aug 11, 2017
Contributor
nkcsgexi
left a comment
nkcsgexi
left a comment
There was a problem hiding this comment.
I've reviewed this in the previous PR. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #11262 to make @swift-ci work 🙏.
// cc @nkcsgexi
This PR includes local variables (
source.lang.swift.decl.var.local) to structures provided by SourceKit. This also makes variables declared inforandwhilestatements available in the structure.Resolves SR-5057.
This is super important for SwiftLint, as you can see on realm/SwiftLint#136 and all duplicated issues. I'm not sure if there's a historical reason for this not be included until now.