Mark the runtime's reimplementation of fixed_seed_override weak#14791
Merged
swift-ci merged 1 commit intoswiftlang:masterfrom Feb 23, 2018
lattner:weak-hashing
Merged
Mark the runtime's reimplementation of fixed_seed_override weak#14791swift-ci merged 1 commit intoswiftlang:masterfrom lattner:weak-hashing
swift-ci merged 1 commit intoswiftlang:masterfrom
lattner:weak-hashing
Conversation
llvm::hashing::detail::fixed_seed_override as weak in case it is staticly linked into an app that includes a real definition from LLVM.
Contributor
|
LGTM. |
jckarter
approved these changes
Feb 23, 2018
Contributor
Author
|
@swift-ci please test and merge |
1 similar comment
Contributor
Author
|
@swift-ci please test and merge |
Contributor
|
Again, we can't do this. Apple internal policy is that we can't use weak definitions. Reverting. |
Contributor
|
We can't use weak definitions with default visibility. This isn't a problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark the runtime's reimplementation of
llvm::hashing::detail::fixed_seed_override as weak in case it is
statically linked into an app that includes a real definition from
LLVM.
This was discussed on swift-dev.